Skip to content

Re-architect triggered meaning for v2 sensors#11

Merged
bachya merged 2 commits intodevfrom
entry-status
Oct 3, 2018
Merged

Re-architect triggered meaning for v2 sensors#11
bachya merged 2 commits intodevfrom
entry-status

Conversation

@bachya
Copy link
Copy Markdown
Owner

@bachya bachya commented Oct 3, 2018

Describe what the PR does:

Follow up to #8. This PR tries to make some more sense of what "triggered" looks like in V2 data. Tactically, there are two changes:

  • Entry sensors will use the entryStatus property from the response data.
  • Any other sensors will raise an exception (until we can determine how their triggered status is communicated via the API).

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests is written for the new functionality.
  • Update README.md with any new documentation.
  • Run tests and ensure 100% code coverage: make coverage (after running make init)
  • Ensure you have no linting errors: make lint (after running make init)
  • Ensure you have no typed your code correctly: make typing (after running make init)
  • Add yourself to AUTHORS.md.

@bachya bachya self-assigned this Oct 3, 2018
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 3, 2018

Codecov Report

Merging #11 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev    #11   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         5      5           
  Lines       247    250    +3     
===================================
+ Hits        247    250    +3
Impacted Files Coverage Δ
simplipy/sensor.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21c187c...735d509. Read the comment docs.

@bachya bachya merged commit fad2711 into dev Oct 3, 2018
@bachya bachya deleted the entry-status branch October 3, 2018 22:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant